Upgrade to Ruby 3 / Rails 7 and remove node.js dependency #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an intermediate step towards ruby 3 / rails 7.
Also upgrade other dependencies as much as possible. Tests are green, but nothing else has been checked so far. Next stop: Ruby 3.
Again, tests are green, nothing else has been checked.
This uses the `importmap-rails` and `dartsass-rails` gems to get rid of node/yarn. Also migrates from turbolinks to its official successor turbo. All webpacker/node/yarn related files should have been removed, but I might have missed some.
This lets rubocop ignore binstubs, that are generated automatically, and configuration files, that due to their nature as such will probably always trigger one or more cops.
Rails 7 simplifies usage of custom configuration loaded with `config_for`. This change makes use of these simplifications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #34 this brings hdm to the current versions of ruby and rails.
Furthermore I removed the old
webpacker-based asset handling and replaced it with a combination ofimportmaps-railsanddartsass-rails.The former allows serving unbundled JS in a clever way, the latter includes a standalone executable of a current, maintained SCSS implementation. Taken together, this means hdm no longer requires node.js.
I tried to adjust the documentation and
Dockerfileaccordingly, but I might have missed something. @rwaffen: I suspect theDockerfilecan be simplified even more now, but I do not understand what is going on 100%, so you might want to have another look.The biggest change when it comes to day to day work with the application, is that for development purposes it no longer suffices to run
rails server. Instead one can use thebin/devscript, that is a small wrapper aroundforeman(the process manager, not the devops tool).foremansimply starts processes defined inProcfile. Besides the rails server there is now also a command to start asassprocess that watches for changes to.scssfiles and compiles them if needed.This is for development purposes only. In a production installation, nothing should change. There, assets need not be compiled on-the-fly, but with the
bin/rails assets:precompiletask once for every deployment/update. Also, for production purposes, the application should run in theproductionrails environment. This is either achieved by starting the server with-e productionor via setting theRAILS_ENVenvironment variable.I am pretty sure we discussed this before, but I could find neither in the existing documentation and scripts. Before this change, this was not a huge issue, but when this is merged, it will lead to problems.